From: Pierangelo Masarati <ando@openldap.org>
Date: Mon, 16 Nov 2009 09:58:12 +0000 (+0000)
Subject: warn if retry is not forever
X-Git-Tag: ACLCHECK_0~108
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=3768fbbd308ba2f08157128b670fc7cb06fd99e4;p=openldap

warn if retry is not forever
---

diff --git a/servers/slapd/syncrepl.c b/servers/slapd/syncrepl.c
index 9b6d4d3c00..80b7c34b7f 100644
--- a/servers/slapd/syncrepl.c
+++ b/servers/slapd/syncrepl.c
@@ -3930,6 +3930,12 @@ parse_syncrepl_retry(
 			}
 		}
 	}
+	if ( j < 1 || si->si_retrynum_init[j-1] != RETRYNUM_FOREVER ) {
+		Debug( LDAP_DEBUG_CONFIG,
+			"%s: syncrepl will eventually stop retrying; the \"retry\" parameter should end with a '+'.\n",
+			c->log, 0, 0 );
+	}
+
 	si->si_retrynum_init[j] = RETRYNUM_TAIL;
 	si->si_retrynum[j] = RETRYNUM_TAIL;
 	si->si_retryinterval[j] = 0;