From: Michael Stapelberg <michael@stapelberg.de>
Date: Tue, 25 Aug 2009 21:16:17 +0000 (+0200)
Subject: Bugfix: Don’t call resize_client if the width/height increment properties did not... 
X-Git-Tag: 3.d~116
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=39f002e0b119373dcadc6a77cb5dcf4e1e47f7cd;p=i3%2Fi3

Bugfix: Don’t call resize_client if the width/height increment properties did not change

This avoids an endless loop, preventing clients to go to fullscreen
---

diff --git a/src/handlers.c b/src/handlers.c
index b8725c1b..49a56f7a 100644
--- a/src/handlers.c
+++ b/src/handlers.c
@@ -1026,13 +1026,23 @@ int handle_normal_hints(void *data, xcb_connection_t *conn, uint8_t state, xcb_w
         }
 
         if ((size_hints.flags & XCB_SIZE_HINT_P_RESIZE_INC)) {
+                bool changed = false;
+
                 if (size_hints.width_inc > 0)
-                        client->width_increment = size_hints.width_inc;
+                        if (client->width_increment != size_hints.width_inc) {
+                                client->width_increment = size_hints.width_inc;
+                                changed = true;
+                        }
                 if (size_hints.height_inc > 0)
-                        client->height_increment = size_hints.height_inc;
+                        if (client->height_increment != size_hints.height_inc) {
+                                client->height_increment = size_hints.height_inc;
+                                changed = true;
+                        }
 
-                resize_client(conn, client);
-                xcb_flush(conn);
+                if (changed) {
+                        resize_client(conn, client);
+                        xcb_flush(conn);
+                }
         }
 
         int base_width = 0, base_height = 0;