From: Pierangelo Masarati <ando@openldap.org>
Date: Thu, 12 Jan 2006 08:16:18 +0000 (+0000)
Subject: add comment about run-time registered extop/control compatibility
X-Git-Tag: OPENLDAP_REL_ENG_2_4_BP~340
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=3a582630376c2f7ca29b0272fa9e68b854e7e8fa;p=openldap

add comment about run-time registered extop/control compatibility
---

diff --git a/servers/slapd/controls.c b/servers/slapd/controls.c
index a8ce25a7ce..049096c29b 100644
--- a/servers/slapd/controls.c
+++ b/servers/slapd/controls.c
@@ -286,6 +286,15 @@ register_supported_control2(const char *controloid,
 
 	} else {
 		if ( sc->sc_extendedopsbv ) {
+			/* FIXME: in principle, we should rather merge
+			 * existing extops with those supported by the
+			 * new control handling implementation.
+			 * In fact, whether a control is compatible with
+			 * an extop should not be a matter of implementation.
+			 * We likely also need a means for a newly
+			 * registered extop to declare that it is
+			 * comptible with an already registered control.
+			 */
 			ber_bvarray_free( sc->sc_extendedopsbv );
 			sc->sc_extendedopsbv = NULL;
 			sc->sc_extendedops = NULL;