From: Pierangelo Masarati <ando@openldap.org>
Date: Mon, 9 Oct 2006 21:18:36 +0000 (+0000)
Subject: minor cleanup
X-Git-Tag: OPENLDAP_REL_ENG_2_3_MP~63
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=3dc7480b8bfe3353e02224db0985ca346a971a78;p=openldap

minor cleanup
---

diff --git a/libraries/libldap/options.c b/libraries/libldap/options.c
index cca205a0d9..eb13790b30 100644
--- a/libraries/libldap/options.c
+++ b/libraries/libldap/options.c
@@ -177,7 +177,7 @@ ldap_get_option(
 
 	case LDAP_OPT_TIMEOUT:
 		/* the caller has to free outvalue ! */
-		if ( ldap_int_timeval_dup( outvalue, lo->ldo_tm_api) != 0 ) {
+		if ( ldap_int_timeval_dup( outvalue, lo->ldo_tm_api ) != 0 ) {
 			return LDAP_OPT_ERROR;
 		}
 		return LDAP_OPT_SUCCESS;
@@ -658,6 +658,7 @@ ldap_set_option(
 	/* read-only options */
 	case LDAP_OPT_API_INFO:
 	case LDAP_OPT_DESC:
+	case LDAP_OPT_SOCKBUF:
 	case LDAP_OPT_API_FEATURE_INFO:
 		return LDAP_OPT_ERROR;
 
@@ -691,14 +692,17 @@ ldap_set_option(
 
 	switch(option) {
 	case LDAP_OPT_DEREF:
+		/* FIXME: check value for protocol compliance? */
 		lo->ldo_deref = * (const int *) invalue;
 		return LDAP_OPT_SUCCESS;
 
 	case LDAP_OPT_SIZELIMIT:
+		/* FIXME: check value for protocol compliance? */
 		lo->ldo_sizelimit = * (const int *) invalue;
 		return LDAP_OPT_SUCCESS;
 
 	case LDAP_OPT_TIMELIMIT:
+		/* FIXME: check value for protocol compliance? */
 		lo->ldo_timelimit = * (const int *) invalue;
 		return LDAP_OPT_SUCCESS;