From: Tom Rini <trini@konsulko.com>
Date: Tue, 9 May 2017 02:14:32 +0000 (-0400)
Subject: net: phy: mv88e61xx: Fix uninitialized variable warning
X-Git-Tag: v2017.07-rc1~299
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=4201223de8e6bac403213ad57769dfa723db36e3;p=u-boot

net: phy: mv88e61xx: Fix uninitialized variable warning

The variable 'res' may be unused uninitialized if our call to
mv88e61xx_port_read (register read) fails and we goto the error
handling section.  In this case we set 'res' to -EIO to indicate why we
failed.

Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Chris Packham <judge.packham@gmail.com>
Cc: Kevin Smith <kevin.smith@elecsyscorp.com>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---

diff --git a/drivers/net/phy/mv88e61xx.c b/drivers/net/phy/mv88e61xx.c
index a2fd1686fc..3d2f6b98ad 100644
--- a/drivers/net/phy/mv88e61xx.c
+++ b/drivers/net/phy/mv88e61xx.c
@@ -655,8 +655,10 @@ static int mv88e61xx_read_port_config(struct phy_device *phydev, u8 port)
 		do {
 			val = mv88e61xx_port_read(phydev, port,
 						  PORT_REG_STATUS);
-			if (val < 0)
+			if (val < 0) {
+				res = -EIO;
 				goto unforce;
+			}
 			if (val & PORT_REG_STATUS_LINK)
 				break;
 		} while (--timeout);