From: Pierangelo Masarati <ando@openldap.org>
Date: Tue, 18 Jan 2005 09:48:53 +0000 (+0000)
Subject: should we touch timestamps when internally updating?
X-Git-Tag: OPENLDAP_REL_ENG_2_3_BP~352
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=42b7753803d69ca862140bfb1fda4d8c73fe3c7e;p=openldap

should we touch timestamps when internally updating?
---

diff --git a/servers/slapd/back-monitor/conn.c b/servers/slapd/back-monitor/conn.c
index 1cb476a18d..40d0a58b91 100644
--- a/servers/slapd/back-monitor/conn.c
+++ b/servers/slapd/back-monitor/conn.c
@@ -217,6 +217,8 @@ monitor_subsys_conn_update(
 		}
 		a->a_vals[ 0 ].bv_len = len;
 		AC_MEMCPY( a->a_vals[ 0 ].bv_val, buf, len + 1 );
+
+		/* FIXME: touch modifyTimestamp? */
 	}
 
 	return( 0 );
diff --git a/servers/slapd/back-monitor/log.c b/servers/slapd/back-monitor/log.c
index ae1108592a..8ab11949e9 100644
--- a/servers/slapd/back-monitor/log.c
+++ b/servers/slapd/back-monitor/log.c
@@ -148,7 +148,9 @@ monitor_subsys_log_modify(
 		Modification	*mod = &ml->sml_mod;
 
 		/*
-		 * accept all operational attributes
+		 * accept all operational attributes;
+		 * this includes modifersName and modifyTimestamp
+		 * if lastmod is "on"
 		 */
 		if ( is_at_operational( mod->sm_desc->ad_type ) ) {
 			( void ) attr_delete( &e->e_attrs, mod->sm_desc );
diff --git a/servers/slapd/back-monitor/operation.c b/servers/slapd/back-monitor/operation.c
index 85295e74dd..8ce09525d3 100644
--- a/servers/slapd/back-monitor/operation.c
+++ b/servers/slapd/back-monitor/operation.c
@@ -215,6 +215,8 @@ monitor_subsys_ops_update(
 	UI2BV( &a->a_vals[ 0 ], nCompleted );
 	ldap_pvt_mp_clear( nCompleted );
 
+	/* FIXME: touch modifyTimestamp? */
+
 	return( 0 );
 }
 
diff --git a/servers/slapd/back-monitor/rww.c b/servers/slapd/back-monitor/rww.c
index 52a5043616..1504846897 100644
--- a/servers/slapd/back-monitor/rww.c
+++ b/servers/slapd/back-monitor/rww.c
@@ -217,6 +217,8 @@ monitor_subsys_rww_update(
 	AC_MEMCPY( a->a_vals[ 0 ].bv_val, buf, len + 1 );
 	a->a_vals[ 0 ].bv_len = len;
 
+	/* FIXME: touch modifyTimestamp? */
+
 	return( 0 );
 }
 
diff --git a/servers/slapd/back-monitor/sent.c b/servers/slapd/back-monitor/sent.c
index c5b459432a..b7ba178f55 100644
--- a/servers/slapd/back-monitor/sent.c
+++ b/servers/slapd/back-monitor/sent.c
@@ -201,6 +201,8 @@ monitor_subsys_sent_update(
 	UI2BV( &a->a_vals[ 0 ], n );
 	ldap_pvt_mp_clear( n );
 
+	/* FIXME: touch modifyTimestamp? */
+
 	return 0;
 }
 
diff --git a/servers/slapd/back-monitor/thread.c b/servers/slapd/back-monitor/thread.c
index f4e8b5878f..83ba5ce522 100644
--- a/servers/slapd/back-monitor/thread.c
+++ b/servers/slapd/back-monitor/thread.c
@@ -197,6 +197,8 @@ monitor_subsys_thread_update(
 	a->a_vals[ 0 ].bv_len = len;
 	AC_MEMCPY( a->a_vals[ 0 ].bv_val, buf, len + 1 );
 
+	/* FIXME: touch modifyTimestamp? */
+
 	return( 0 );
 }
 
diff --git a/servers/slapd/back-monitor/time.c b/servers/slapd/back-monitor/time.c
index bc4056b939..016b233613 100644
--- a/servers/slapd/back-monitor/time.c
+++ b/servers/slapd/back-monitor/time.c
@@ -224,6 +224,8 @@ monitor_subsys_time_update(
 
 		assert( len == a->a_vals[ 0 ].bv_len );
 		AC_MEMCPY( a->a_vals[ 0 ].bv_val, tmbuf, len );
+
+		/* FIXME: touch modifyTimestamp? */
 	}
 
 	return( 0 );