From: Pierangelo Masarati Date: Tue, 12 Apr 2005 17:01:31 +0000 (+0000) Subject: add comment (see ITS#3652) X-Git-Tag: OPENLDAP_AC_BP~916 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=42dda802bac669822db11ee0f9beeb7e9de8ce06;p=openldap add comment (see ITS#3652) --- diff --git a/servers/slapd/backover.c b/servers/slapd/backover.c index eb0bf89c19..1994ba7ff8 100644 --- a/servers/slapd/backover.c +++ b/servers/slapd/backover.c @@ -273,6 +273,7 @@ over_access_allowed( for ( ; on; on = on->on_next ) { if ( on->on_bi.bi_access_allowed ) { + /* NOTE: do not copy the structure until required */ if ( !SLAP_ISOVERLAY( op->o_bd ) ) { db = *op->o_bd; db.be_flags |= SLAP_DBFLAG_OVERLAY; @@ -287,6 +288,11 @@ over_access_allowed( } if ( rc == SLAP_CB_CONTINUE && oi->oi_orig->bi_access_allowed ) { + /* NOTE: do not copy the structure until requiredy */ + /* NOTE: by default, oi->oi_orig->bi_access_allowed == NULL; + * only backends that implement a specific hook + * should store it there; by default, slap_access_allowed() + * is invoked if oi->oi_orig->bi_access_allowed == NULL */ if ( !SLAP_ISOVERLAY( op->o_bd ) ) { db = *op->o_bd; db.be_flags |= SLAP_DBFLAG_OVERLAY;