From: Scott Barninger <scott@barninger.com>
Date: Sun, 5 Dec 2004 14:39:06 +0000 (+0000)
Subject: Fix permissions on bacula-fd.conf. A last cleanup on the uninstall.
X-Git-Tag: Release-1.38.0~719
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=42fdf689ed335fea62ac3df6f82f6eb69fa45c8c;p=bacula%2Fbacula

Fix permissions on bacula-fd.conf. A last cleanup on the uninstall.


git-svn-id: https://bacula.svn.sourceforge.net/svnroot/bacula/trunk@1745 91ce42f0-d328-0410-95d8-f526ca767f89
---

diff --git a/bacula/src/win32/winbacula.nsi.in b/bacula/src/win32/winbacula.nsi.in
index ce98b43ed5..349e2e54ce 100755
--- a/bacula/src/win32/winbacula.nsi.in
+++ b/bacula/src/win32/winbacula.nsi.in
@@ -11,6 +11,12 @@
 ; added Start Menu items
 ; fix uninstall of config files to do all not just bacula-fd.conf
 ;
+; D. Scott Barninger Dec 05 2004
+; added specification of default permissions for bacula-fd.conf
+;   - thanks to Jamie Ffolliott for pointing me at cacls
+; added removal of working-dir files if user selects to remove config
+; uninstall is now 100% clean
+;
 ; Command line options:
 ;
 ; /cygwin     -  do cygwin install into c:\cygwin\bacula
@@ -154,8 +160,11 @@ Section "Bacula File Service" SecService
   Call IsNt
   Pop $R0
   StrCmp $R0 "false" do_win98
-  MessageBox MB_YESNO|MB_ICONQUESTION  "Would you like to start the Bacula Client now?" IDNO NoStart
+  MessageBox MB_YESNO|MB_ICONQUESTION  "Would you like to start the Bacula Client now?" IDNO SetPerms
   Exec 'net start bacula'
+ SetPerms:
+  ; set default permissions on config file so it's not world readable
+  Exec 'cmd /C echo Y|cacls "$INSTDIR\bin\bacula-fd.conf" /G SYSTEM:F Administrators:F'
   goto NoStart 
  do_win98:
   File Start.bat
@@ -274,8 +283,9 @@ Section "Uninstall"
   Delete /REBOOTOK "$INSTDIR\Uninstall.exe"
 
   ; Check for existing installation
-  MessageBox MB_YESNO|MB_ICONQUESTION "Would you like to delete the current configuration files?" IDNO LeaveConfig
+  MessageBox MB_YESNO|MB_ICONQUESTION "Would you like to delete the current configuration files and the working state file?" IDNO LeaveConfig
   Delete /REBOOTOK "$INSTDIR\bin\*.conf"
+  Delete /REBOOTOK "$INSTDIR\working\*"
   ; remove directories used
   RMDir "$INSTDIR\bin"
   RMDir "$INSTDIR\doc"