From: Howard Chu <hyc@openldap.org>
Date: Fri, 3 Feb 2012 19:58:00 +0000 (-0800)
Subject: ITS#7143 add FIXME comment, note that current patch is not ideal
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=430256fafb85028443d7964a5ab1f4bbf8b2db38;p=openldap

ITS#7143 add FIXME comment, note that current patch is not ideal
---

diff --git a/servers/slapd/overlays/rwm.c b/servers/slapd/overlays/rwm.c
index 37e52cb71d..cc6211ed25 100644
--- a/servers/slapd/overlays/rwm.c
+++ b/servers/slapd/overlays/rwm.c
@@ -1277,6 +1277,12 @@ rwm_attrs( Operation *op, SlapReply *rs, Attribute** a_first, int stripEntryDN )
 								NULL );
 
 							if ( rc != LDAP_SUCCESS ) {
+								/* FIXME: this is wrong, putting a non-normalized value
+								 * into nvals. But when a proxy sends us bogus data,
+								 * we still need to give it to the client, even if it
+								 * violates the syntax. I.e., we don't want to silently
+								 * drop things and trigger an apparent data loss.
+								 */
 								ber_dupbv( &(*ap)->a_nvals[i], &(*ap)->a_vals[i] );
 							}
 						}