From: Stephen Warren Date: Sat, 3 Oct 2015 19:56:48 +0000 (-0600) Subject: fs-test.sh: fix pre-requisite detection X-Git-Tag: v2016.01-rc1~175 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=47b71644500f7dff768254570ff62c6e985e4bc3;p=u-boot fs-test.sh: fix pre-requisite detection In the following snippet: if [ ! -x `which $prereq` ]; then When $prereq does not exist, `which $prereq` evaluates to the empty string, which results in *no* argument being passed to the -x operator, which then evaluates to true, which is the equivalent of the prereq having been found. In order for this to fail as expected, we must pass an empty argument, which then causes -x to fail. Do this by wrapping the `` in quotes so there's always an argument to -x, even if the value of the argument is zero-length. Signed-off-by: Stephen Warren Reviewed-by: Simon Glass Tested-by: Simon Glass --- diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh index 6f0a3455ed..fc41c04c15 100755 --- a/test/fs/fs-test.sh +++ b/test/fs/fs-test.sh @@ -58,7 +58,7 @@ GB2p5="${MOUNT_DIR}/${BIG_FILE}" # Check if the prereq binaries exist, or exit function check_prereq() { for prereq in $PREREQ_BINS; do - if [ ! -x `which $prereq` ]; then + if [ ! -x "`which $prereq`" ]; then echo "Missing $prereq binary. Exiting!" exit fi