From: cuz <cuz@b7a2c559-68d2-44c3-8de9-860c34a00d81>
Date: Mon, 14 Oct 2002 16:23:26 +0000 (+0000)
Subject: Fixed a buffer overflow (report from Christian Groessler).
X-Git-Tag: V2.12.0~2168
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=49fd7134e51d012b1c96497978fb7a55afb3b094;p=cc65

Fixed a buffer overflow (report from Christian Groessler).


git-svn-id: svn://svn.cc65.org/cc65/trunk@1464 b7a2c559-68d2-44c3-8de9-860c34a00d81
---

diff --git a/src/cc65/compile.c b/src/cc65/compile.c
index d044a0966..0e751edf9 100644
--- a/src/cc65/compile.c
+++ b/src/cc65/compile.c
@@ -39,6 +39,7 @@
 /* common */
 #include "version.h"
 #include "xmalloc.h"
+#include "xsprintf.h"
 
 /* cc65 */
 #include "asmlabel.h"
@@ -257,10 +258,20 @@ static void Parse (void)
 void Compile (const char* FileName)
 /* Top level compile routine. Will setup things and call the parser. */
 {
-    char*  Path;
-    char   Buf[16];
-    time_t Time;
-    char*  TimeStr;
+    char*       Path;
+    char        Buf[20];
+    char        DateStr[20];
+    char        TimeStr[20];
+    time_t      Time;
+    struct tm*  TM;
+
+    /* Since strftime is locale dependent, we need the abbreviated month names
+     * in english.
+     */
+    static const char MonthNames[12][4] = {
+        "Jan", "Feb", "Mar", "Apr", "May", "Jun",
+        "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"
+    };
 
     /* Add some standard paths to the include search path */
     AddIncludePath ("", INC_USER);		/* Current directory */
@@ -299,11 +310,12 @@ void Compile (const char* FileName)
 
     /* __TIME__ and __DATE__ macros */
     Time = time (0);
-    TimeStr = ctime (&Time);
-    sprintf (Buf, "\"%.10s\"", TimeStr);
-    DefineTextMacro ("__DATE__", Buf);
-    sprintf (Buf, "\"%.15s\"", TimeStr+11);
-    DefineTextMacro ("__TIME__", Buf);
+    TM   = localtime (&Time);
+    strftime (Buf, sizeof (Buf), "%e %Y", TM);
+    xsprintf (DateStr, sizeof (DateStr), "\"%s %s\"", MonthNames[TM->tm_mon], Buf);
+    strftime (TimeStr, sizeof (TimeStr), "\"%H:%M:%S\"", TM);
+    DefineTextMacro ("__DATE__", DateStr);
+    DefineTextMacro ("__TIME__", TimeStr);
 
     /* Initialize the literal pool */
     InitLiteralPool ();