From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Fri, 29 Dec 2017 17:00:07 +0000 (+0900)
Subject: mmc: let mmc_of_parse() fail for insane bus-width value
X-Git-Tag: v2018.03-rc1~99^2~12
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=4b28f7bc930347cb99a6ee2f213ce9db34e36697;p=u-boot

mmc: let mmc_of_parse() fail for insane bus-width value

You must fix your DT if it specifies insane bus-width, for example,
  bus-width = <3>;

debug() is not displayed in usual configuration, so people will not
even notice weirdness.  Use dev_err() instead, then let it fail.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
index 7910a3e278..a3536b15ae 100644
--- a/drivers/mmc/mmc-uclass.c
+++ b/drivers/mmc/mmc-uclass.c
@@ -140,10 +140,8 @@ int mmc_of_parse(struct udevice *dev, struct mmc_config *cfg)
 		cfg->host_caps |= MMC_MODE_1BIT;
 		break;
 	default:
-		debug("warning: %s invalid bus-width property. using 1-bit\n",
-		      dev_read_name(dev));
-		cfg->host_caps |= MMC_MODE_1BIT;
-		break;
+		dev_err(dev, "Invalid \"bus-width\" value %u!\n", val);
+		return -EINVAL;
 	}
 
 	/* f_max is obtained from the optional "max-frequency" property */