From: Simon Glass <sjg@chromium.org>
Date: Wed, 7 Jun 2017 16:28:44 +0000 (-0600)
Subject: test: bus: Add a check that dev is not NULL
X-Git-Tag: v2017.07-rc2~40
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=4f414d392fb5d7c4ac547c4ee9f02b81648c00dd;p=u-boot

test: bus: Add a check that dev is not NULL

We know that uclass_get_device() and device_find_child_by_of_offset() do
not return NULL for dev when they succeeds but coverity does not. Add an
extra check to hopefully keep it happy.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 163246)
Fixes: 0753bc2 (dm: Simple Watchdog uclass)
---

diff --git a/test/dm/bus.c b/test/dm/bus.c
index 8ba75d4b7d..7006d4163d 100644
--- a/test/dm/bus.c
+++ b/test/dm/bus.c
@@ -171,13 +171,16 @@ static int dm_test_bus_children_of_offset(struct unit_test_state *uts)
 	int node;
 
 	ut_assertok(uclass_get_device(UCLASS_TEST_BUS, 0, &bus));
+	ut_assertnonnull(bus);
 
 	/* Find a valid child */
 	node = fdt_path_offset(blob, "/some-bus/c-test@1");
 	ut_assert(node > 0);
 	ut_assertok(device_find_child_by_of_offset(bus, node, &dev));
+	ut_assertnonnull(dev);
 	ut_assert(!(dev->flags & DM_FLAG_ACTIVATED));
 	ut_assertok(device_get_child_by_of_offset(bus, node, &dev));
+	ut_assertnonnull(dev);
 	ut_assert(dev->flags & DM_FLAG_ACTIVATED);
 
 	return 0;