From: Howard Chu <hyc@openldap.org>
Date: Mon, 29 Nov 2004 08:55:50 +0000 (+0000)
Subject: Fix slap_known_controls initialization
X-Git-Tag: OPENLDAP_REL_ENG_2_3_0ALPHA~183
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=4fec2f56df14080f5063ef57b89e30bf32a1dc98;p=openldap

Fix slap_known_controls initialization
---

diff --git a/servers/slapd/controls.c b/servers/slapd/controls.c
index 9b98a91190..76e470efe6 100644
--- a/servers/slapd/controls.c
+++ b/servers/slapd/controls.c
@@ -192,7 +192,7 @@ register_supported_control(const char *controloid,
 	if ( controloid == NULL ) return LDAP_PARAM_ERROR;
 
 	/* sanity check - should never happen */
-	for ( i = 1; slap_known_controls[ i ]; i++ ) {
+	for ( i = 0; slap_known_controls[ i ]; i++ ) {
 		if ( strcmp( controloid, slap_known_controls[ i ] ) == 0 ) {
 			Debug( LDAP_DEBUG_ANY,
 				"Control %s already registered.\n",
@@ -221,8 +221,8 @@ register_supported_control(const char *controloid,
 	sc->sc_cid = num_known_controls;
 
 	/* Update slap_known_controls, too. */
-	slap_known_controls[num_known_controls++] = sc->sc_oid;
-	slap_known_controls[num_known_controls] = NULL;
+	slap_known_controls[num_known_controls-1] = sc->sc_oid;
+	slap_known_controls[num_known_controls++] = NULL;
 
 	LDAP_SLIST_NEXT( sc, sc_next ) = NULL;
 	LDAP_SLIST_INSERT_HEAD( &controls_list, sc, sc_next );