From: Upakul Barkakaty <upakul@gmail.com>
Date: Thu, 29 Nov 2007 06:46:13 +0000 (+0530)
Subject: NET: Proper return code handling in eth_init() function in file eth.c
X-Git-Tag: v1.3.2-rc1~102^2~49^2~37
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=505be87a65e4f87ad7d8da1d57ea4dcd487d7e32;p=u-boot

NET: Proper return code handling in eth_init() function in file eth.c

This patch modifies the return code handling in the eth_init()
function, to be compatible with the handling of the return codes in
the other network stack files. It now returns a 0 on Success and -1 on
error.

Signed-off-by: Upakul Barkakaty <upakul.barkakaty@conexant.com>
Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
---

diff --git a/net/eth.c b/net/eth.c
index 425f29edba..3373a05252 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -424,23 +424,23 @@ int eth_init(bd_t *bis)
 	struct eth_device* old_current;
 
 	if (!eth_current)
-		return 0;
+		return -1;
 
 	old_current = eth_current;
 	do {
 		debug ("Trying %s\n", eth_current->name);
 
-		if (eth_current->init(eth_current, bis)) {
+		if (!eth_current->init(eth_current,bis)) {
 			eth_current->state = ETH_STATE_ACTIVE;
 
-			return 1;
+			return 0;
 		}
 		debug  ("FAIL\n");
 
 		eth_try_another(0);
 	} while (old_current != eth_current);
 
-	return 0;
+	return -1;
 }
 
 void eth_halt(void)