From: Bin Meng Date: Sun, 27 Aug 2017 02:22:58 +0000 (-0700) Subject: x86: ich-spi: Remove useless assignment in ich_spi_xfer() X-Git-Tag: v2017.09-rc4~27^2~3 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=52dd56ba847acd048205e6412e779fda991c95d3;p=u-boot x86: ich-spi: Remove useless assignment in ich_spi_xfer() In ich_spi_xfer() when the driver presets control fields, control variable gets assigned twice. Apparently only the last assignment takes effect. Remove the other one. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese --- diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c index 373bc2683b..5a3d690815 100644 --- a/drivers/spi/ich.c +++ b/drivers/spi/ich.c @@ -468,8 +468,6 @@ static int ich_spi_xfer(struct udevice *dev, unsigned int bitlen, } /* Preset control fields */ - control = ich_readw(ctlr, ctlr->control); - control &= ~SSFC_RESERVED; control = SPIC_SCGO | ((opcode_index & 0x07) << 4); /* Issue atomic preop cycle if needed */