From: Howard Chu <hyc@openldap.org>
Date: Fri, 13 May 2005 01:35:20 +0000 (+0000)
Subject: ITS#3608 - ignore unavailable non-critical controls
X-Git-Tag: OPENLDAP_AC_BP~653
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=55585110bf708fe5939a8961c7f2a9f0da1b5a21;p=openldap

ITS#3608 - ignore unavailable non-critical controls
---

diff --git a/servers/slapd/backend.c b/servers/slapd/backend.c
index 17a92e79aa..f8dda1c50a 100644
--- a/servers/slapd/backend.c
+++ b/servers/slapd/backend.c
@@ -821,7 +821,7 @@ backend_check_controls(
 				break;
 
 			case LDAP_COMPARE_FALSE:
-				if ( !op->o_bd->be_ctrls[ cid ] )
+				if ( !op->o_bd->be_ctrls[ cid ] && (*ctrls)->ldctl_iscritical )
 				{
 					/* Per RFC 2251 (and LDAPBIS discussions), if the control
 					 * is recognized and appropriate for the operation (which
@@ -829,10 +829,11 @@ backend_check_controls(
 					 * use of the control when performing the operation.
 					 * 
 					 * Here we find that operation extended by the control
-					 * is not unavailable in a particular context, hence the
-					 * return of unwillingToPerform.
+					 * is unavailable in a particular context, and the control
+					 * is marked Critical, hence the return of
+					 * unwillingToPerform.
 					 */
-					rs->sr_text = "control unavailable in context";
+					rs->sr_text = "critical control unavailable in context";
 					rs->sr_err = LDAP_UNWILLING_TO_PERFORM;
 					goto done;
 				}