From: Kern Sibbald <kern@sibbald.com>
Date: Sun, 26 Nov 2006 16:01:26 +0000 (+0000)
Subject: Add Bacula version+date to Client record. This is a very minor
X-Git-Tag: Release-2.0.0~211
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=5f08b1f274656ca522d7d12116493b757964cbfe;p=bacula%2Fbacula

Add Bacula version+date to Client record. This is a very minor
     security problem in that passing the version facilitates a hacker's
     life, but it will make support easier.


git-svn-id: https://bacula.svn.sourceforge.net/svnroot/bacula/trunk@3706 91ce42f0-d328-0410-95d8-f526ca767f89
---

diff --git a/bacula/kernstodo b/bacula/kernstodo
index 0da65c17df..4571380e34 100644
--- a/bacula/kernstodo
+++ b/bacula/kernstodo
@@ -41,6 +41,8 @@ Document:
  
 
 Priority:
+- Ensure that the SD re-reads the Media record if the JobFiles
+  does not match -- it may have been updated by another job.
 - Look at moving the Storage directive from the Job to the
   Pool in the default conf files.
 - Make sure the new level=Full syntax is used in all 
diff --git a/bacula/src/filed/job.c b/bacula/src/filed/job.c
index 00d2da45e3..e7d5234655 100644
--- a/bacula/src/filed/job.c
+++ b/bacula/src/filed/job.c
@@ -134,7 +134,7 @@ static char OKverify[]    = "2000 OK verify\n";
 static char OKrestore[]   = "2000 OK restore\n";
 static char OKsession[]   = "2000 OK session\n";
 static char OKstore[]     = "2000 OK storage\n";
-static char OKjob[]       = "2000 OK Job %s,%s,%s";
+static char OKjob[]       = "2000 OK Job %s (%s) %s,%s,%s";
 static char OKsetdebug[]  = "2000 OK setdebug=%d\n";
 static char BADjob[]      = "2901 Bad Job\n";
 static char EndJob[]      = "2800 End Job TermCode=%d JobFiles=%u ReadBytes=%s JobBytes=%s Errors=%u\n";
@@ -432,7 +432,7 @@ static int job_cmd(JCR *jcr)
    jcr->sd_auth_key = bstrdup(sd_auth_key);
    free_pool_memory(sd_auth_key);
    Dmsg2(120, "JobId=%d Auth=%s\n", jcr->JobId, jcr->sd_auth_key);
-   return bnet_fsend(dir, OKjob, HOST_OS, DISTNAME, DISTVER);
+   return bnet_fsend(dir, OKjob, VERSION, LSMDATE, HOST_OS, DISTNAME, DISTVER);
 }
 
 static int runbefore_cmd(JCR *jcr)
diff --git a/bacula/technotes-1.39 b/bacula/technotes-1.39
index d83dd3950d..0a98bda7a7 100644
--- a/bacula/technotes-1.39
+++ b/bacula/technotes-1.39
@@ -2,6 +2,9 @@
 
 General:
 26Nov06
+kes  Add Bacula version+date to Client record. This is a very minor
+     security problem in that passing the version facilitates a hacker's
+     life, but it will make support easier.
 kes  Implement fixes to make disk seeking work.  Currently turned
      off in version.h pending reserch on what problems it will cause
      because of the previous bsnprinf() sign extension bug.