From: Michael Stapelberg <michael@stapelberg.de>
Date: Tue, 28 May 2013 17:52:01 +0000 (+0200)
Subject: Bugfix: Unmap windows before reparenting them to the root window (fixes Mathematica... 
X-Git-Tag: 4.6~32^2^2
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=62ef7834b042409acb99f0a030729c806be69335;p=i3%2Fi3

Bugfix: Unmap windows before reparenting them to the root window (fixes Mathematica) (Thanks psychon)

Some apps such as Mathematica send a synthetic UnmapNotify event without
properly unmapping their window first. This change makes sure that
happens and fixes an annoying bug with Mathematica where some unmanaged
windows would stay around, but you couldn’t do anything with them.

Thanks to psychon (current awesome maintainer) for helping with the
diagnosis!

fixes #787
---

diff --git a/src/tree.c b/src/tree.c
index 32bec965..6d23750f 100644
--- a/src/tree.c
+++ b/src/tree.c
@@ -235,7 +235,12 @@ bool tree_close(Con *con, kill_window_t kill_window, bool dont_kill_parent, bool
             return false;
         } else {
             xcb_void_cookie_t cookie;
-            /* un-parent the window */
+            /* Ignore any further events by clearing the event mask,
+             * unmap the window,
+             * then reparent it to the root window. */
+            xcb_change_window_attributes(conn, con->window->id,
+                    XCB_CW_EVENT_MASK, (uint32_t[]){ XCB_NONE });
+            xcb_unmap_window(conn, con->window->id);
             cookie = xcb_reparent_window(conn, con->window->id, root, 0, 0);
 
             /* Ignore X11 errors for the ReparentWindow request.