From: Tom Rini <trini@konsulko.com>
Date: Wed, 10 May 2017 19:20:14 +0000 (-0400)
Subject: cmd/led.c: Remove unnecessary check on 'cmd' value
X-Git-Tag: v2017.07-rc1~289
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=62f733b396cbe39315e9f28ea348300c6a72caa9;p=u-boot

cmd/led.c: Remove unnecessary check on 'cmd' value

We first check that if argc is less than 2 we return CMD_RET_USAGE.  We
then see if argc is greater than 2 and if so call get_led_cmd() to set
'cmd' and otherwise set it to LEDST_COUNT (which will always be positive
as it's an enum with 0 already assigned).  Therefore the test on if cmd
is less than 0 will always be false and simply be omitted.  Reported by
clang-3.8.

Signed-off-by: Tom Rini <trini@konsulko.com>
---

diff --git a/cmd/led.c b/cmd/led.c
index 84173f86f2..bdfb16c0e0 100644
--- a/cmd/led.c
+++ b/cmd/led.c
@@ -90,8 +90,6 @@ int do_led(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		return list_leds();
 
 	cmd = argc > 2 ? get_led_cmd(argv[2]) : LEDST_COUNT;
-	if (cmd < 0)
-		return CMD_RET_USAGE;
 #ifdef CONFIG_LED_BLINK
 	if (cmd == LEDST_BLINK) {
 		if (argc < 4)