From: Luke Howard <lukeh@openldap.org>
Date: Fri, 27 Aug 2004 19:34:14 +0000 (+0000)
Subject: Remove bogus SLAPI code path which special-cased modlist == NULL
X-Git-Tag: OPENLDAP_REL_ENG_2_3_0ALPHA~619
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=6cdaa19b96ceea7fb255d88a54d7300656aa8842;p=openldap

Remove bogus SLAPI code path which special-cased modlist == NULL

This had the effect of setting the result code to LDAP_SUCCESS for modlist == NULL
even on a replica when an update-ref might be set. This was causing a plugin (that
implements the commit phase in a post-op plugin) to write to "read-only" replica.
---

diff --git a/servers/slapd/modify.c b/servers/slapd/modify.c
index bfb2842108..70f282a396 100644
--- a/servers/slapd/modify.c
+++ b/servers/slapd/modify.c
@@ -470,10 +470,6 @@ fe_op_modify( Operation *op, SlapReply *rs )
 	 * However, the post-operation plugin should still be 
 	 * called.
 	 */
-	if ( modlist == NULL ) {
-		rs->sr_err = LDAP_SUCCESS;
-		send_ldap_result( op, rs );
-	} else {
 #endif /* defined( LDAP_SLAPI ) */
 
 	/*
@@ -560,8 +556,6 @@ fe_op_modify( Operation *op, SlapReply *rs )
 	}
 
 #if defined( LDAP_SLAPI )
-	} /* modlist != NULL */
-
 	if ( pb != NULL && slapi_int_call_plugins( op->o_bd,
 		SLAPI_PLUGIN_POST_MODIFY_FN, pb ) < 0 )
 	{