From: Thomas Weber Date: Wed, 24 Nov 2010 12:07:51 +0000 (+0100) Subject: Common/command: Guard strchr/strlen from NULL pointer X-Git-Tag: v2010.12-rc2~12 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=7013c06124e9760f75ef194d429ed29fba843eb9;p=u-boot Common/command: Guard strchr/strlen from NULL pointer Guard strchr/strlen from being called with NULL pointer. This line is crashing when command "env" is called without subcommand. The cmd is NULL in this case because the calling function "do_env" decremented the argc without checking if there are still arguments available. Signed-off-by: Thomas Weber --- diff --git a/common/command.c b/common/command.c index 0020eacf5c..0b1a3fbf9b 100644 --- a/common/command.c +++ b/common/command.c @@ -108,6 +108,8 @@ cmd_tbl_t *find_cmd_tbl (const char *cmd, cmd_tbl_t *table, int table_len) int len; int n_found = 0; + if (!cmd) + return NULL; /* * Some commands allow length modifiers (like "cp.b"); * compare command name only until first dot.