From: Zachary T Welch <zw@superlucidity.net>
Date: Thu, 19 Nov 2009 15:26:28 +0000 (-0800)
Subject: change command_find helper interface
X-Git-Tag: v0.4.0-rc1~476
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=73c6e3bb18326050acc8908b561443a7b37549bb;p=openocd

change command_find helper interface

Avoid requiring double pointers where a single would suffice.
---

diff --git a/src/helper/command.c b/src/helper/command.c
index ba28784d..538c07bb 100644
--- a/src/helper/command.c
+++ b/src/helper/command.c
@@ -205,10 +205,9 @@ static void command_helptext_add(Jim_Obj *cmd_list, const char *help)
  * Find a command by name from a list of commands.
  * @returns The named command if found, or NULL.
  */
-static struct command *command_find(struct command **head, const char *name)
+static struct command *command_find(struct command *head, const char *name)
 {
-	assert(head);
-	for (struct command *cc = *head; cc; cc = cc->next)
+	for (struct command *cc = head; cc; cc = cc->next)
 	{
 		if (strcmp(cc->name, name) == 0)
 			return cc;
@@ -242,7 +241,7 @@ struct command* register_command(struct command_context *context,
 		return NULL;
 
 	struct command **head = parent ? &parent->children : &context->commands;
-	struct command *c = command_find(head, name);
+	struct command *c = command_find(*head, name);
 	if (NULL != c)
 		return c;