From: Kern Sibbald <kern@sibbald.com>
Date: Thu, 17 Apr 2008 16:31:00 +0000 (+0000)
Subject: Fix bat
X-Git-Tag: Release-2.4.0~62
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=73f903ef92769a38d25e074df8d1f63311351825;p=bacula%2Fbacula

Fix bat

git-svn-id: https://bacula.svn.sourceforge.net/svnroot/bacula/branches/Branch-2.2@6836 91ce42f0-d328-0410-95d8-f526ca767f89
---

diff --git a/bacula/src/qt-console/console/console.cpp b/bacula/src/qt-console/console/console.cpp
index fd4273b3b6..77106b2bb8 100644
--- a/bacula/src/qt-console/console/console.cpp
+++ b/bacula/src/qt-console/console/console.cpp
@@ -103,6 +103,11 @@ void Console::poll_messages()
 void Console::terminate()
 {
    if (m_sock) {
+      if (m_notifier) {
+         m_notifier->setEnabled(false);
+         delete m_notifier;
+         m_notifier = NULL;
+      }
       stopTimer();
       m_sock->close();
       m_sock = NULL;
diff --git a/bacula/src/qt-console/mainwin.cpp b/bacula/src/qt-console/mainwin.cpp
index 079c2a2f7a..4bda5d7674 100644
--- a/bacula/src/qt-console/mainwin.cpp
+++ b/bacula/src/qt-console/mainwin.cpp
@@ -247,16 +247,6 @@ void MainWin::closeEvent(QCloseEvent *event)
 {
    m_isClosing = true;
    writeSettings();
-   /*
-    * Close the console pages before non-console pages so that
-    *  the notifier is turned off. Otherwise it prints an error when
-    *  the page it is using gets destroyed.
-    */
-   foreach(Console *console, m_consoleHash){
-      console->writeSettings();
-      console->terminate();
-      console->closeStackPage();
-   }
    /* close all non console pages, this will call settings in destructors */
    while (m_consoleHash.count() < m_pagehash.count()) {
       foreach(Pages *page, m_pagehash) {
@@ -269,6 +259,16 @@ void MainWin::closeEvent(QCloseEvent *event)
          }
       }
    }
+   /*
+    * Close the console pages before non-console pages so that
+    *  the notifier is turned off. Otherwise it prints an error when
+    *  the page it is using gets destroyed.
+    */
+   foreach(Console *console, m_consoleHash){
+      console->writeSettings();
+      console->terminate();
+      console->closeStackPage();
+   }
    event->accept();
 }
 
diff --git a/bacula/technotes-2.1 b/bacula/technotes-2.1
index bdba766de4..2fed7b2885 100644
--- a/bacula/technotes-2.1
+++ b/bacula/technotes-2.1
@@ -1,6 +1,10 @@
               Technical notes on version 2.2
 
 General:
+17Apr08
+kes  Fix seg fault terminating bat.
+
+Beta Release Version 2.2.10-b1
 16Apr08
 kes  Permit multiple simultaneous restores -- experiment.
 15Apr08