From: Tom Rini <trini@konsulko.com>
Date: Sun, 22 Apr 2018 13:47:48 +0000 (-0400)
Subject: video-uclass: Fix logical-not-parentheses warning
X-Git-Tag: v2018.05-rc3~40^2
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=751641814c1db245695dd8f40e9c811320e69f79;p=u-boot

video-uclass: Fix logical-not-parentheses warning

With clang-4.0 and later we see:
warning: logical not is only applied to the left hand side of this bitwise
operator [-Wlogical-not-parentheses]
        if ((!gd->flags & GD_FLG_RELOC))
             ^          ~

And while the compiler suggests adding parenthesis around gd->flags, a
reading of the code says that we want to know when GD_FLG_RELOC is not
set and then return.

Cc: Simon Glass <sjg@chromium.org>
Cc: Anatolij Gustschin <agust@denx.de>
Signed-off-by: Tom Rini <trini@konsulko.com>
---

diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
index b5bb8e0efd..93fdc6828b 100644
--- a/drivers/video/video-uclass.c
+++ b/drivers/video/video-uclass.c
@@ -272,7 +272,7 @@ static int video_post_bind(struct udevice *dev)
 	ulong size;
 
 	/* Before relocation there is nothing to do here */
-	if ((!gd->flags & GD_FLG_RELOC))
+	if (!(gd->flags & GD_FLG_RELOC))
 		return 0;
 	size = alloc_fb(dev, &addr);
 	if (addr < gd->video_bottom) {