From: Pierangelo Masarati <ando@openldap.org>
Date: Wed, 20 Jul 2005 00:50:35 +0000 (+0000)
Subject: more on deadlock/dangling pointers
X-Git-Tag: OPENLDAP_AC_BP~314
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=77ad940c10f32cb6c6f68944da2049a86d850bf4;p=openldap

more on deadlock/dangling pointers
---

diff --git a/servers/slapd/back-monitor/search.c b/servers/slapd/back-monitor/search.c
index db3d6ab5be..591287d06c 100644
--- a/servers/slapd/back-monitor/search.c
+++ b/servers/slapd/back-monitor/search.c
@@ -125,7 +125,7 @@ monitor_send_children(
 			if ( rc ) {
 				/* FIXME: may leak generated children */
 				if ( nonvolatile == 0 ) {
-					for ( e_tmp = e; e_tmp != NULL; ) {
+					for ( ; e_tmp != NULL; ) {
 						mp = ( monitor_entry_t * )e_tmp->e_private;
 						e = e_tmp;
 						e_tmp = mp->mp_next;
@@ -135,9 +135,6 @@ monitor_send_children(
 							break;
 						}
 					}
-
-				} else {
-					monitor_cache_release( mi, e );
 				}
 
 				return( rc );