From: Salvador Arroyo Date: Sun, 11 Nov 2012 17:06:57 +0000 (+0100) Subject: mips: patch mips32_pracc_exec_write() X-Git-Tag: v0.7.0-rc1~151 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=78807eb6ec79b4ea2a6a1fa4aa074d6ccd56b4b0;p=openocd mips: patch mips32_pracc_exec_write() No function writes to MIPS32_PRACC_PARAM_IN addresses and probably has no much sense. Any attempt to write to those addresses should be an error. Change-Id: Iebea5fa9954e2cd56ad34976dd7d25009c6e6388 Signed-off-by: Salvador Arroyo Reviewed-on: http://openocd.zylin.com/975 Tested-by: jenkins Reviewed-by: Spencer Oliver --- diff --git a/src/target/mips32_pracc.c b/src/target/mips32_pracc.c index 787daefe..87e712bc 100644 --- a/src/target/mips32_pracc.c +++ b/src/target/mips32_pracc.c @@ -194,11 +194,7 @@ static int mips32_pracc_exec_write(struct mips32_pracc_context *ctx, uint32_t ad if (retval != ERROR_OK) return retval; - if ((address >= MIPS32_PRACC_PARAM_IN) - && (address < MIPS32_PRACC_PARAM_IN + ctx->num_iparam * 4)) { - offset = (address - MIPS32_PRACC_PARAM_IN) / 4; - ctx->local_iparam[offset] = data; - } else if ((address >= MIPS32_PRACC_PARAM_OUT) + if ((address >= MIPS32_PRACC_PARAM_OUT) && (address < MIPS32_PRACC_PARAM_OUT + ctx->num_oparam * 4)) { offset = (address - MIPS32_PRACC_PARAM_OUT) / 4; ctx->local_oparam[offset] = data;