From: Kurt Zeilenga Date: Mon, 15 Apr 2002 20:44:05 +0000 (+0000) Subject: Patch: aclparse.c bugs (ITS#1752) X-Git-Tag: OPENLDAP_REL_ENG_2_MP~195 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=8354160f8b01d219d69178c88f9062be3699abe2;p=openldap Patch: aclparse.c bugs (ITS#1752) ================ Written by Hallvard B. Furuseth and placed into the public domain. This software is not subject to any license of the University of Oslo. ================ Bug fixes: - acl_regex_normalized_dn(pattern): * used pattern->bv_len even though it claimed not to, * would walk past the end of strings that ended (incorrectly) with a single '\'. - style=regex checked for "^.*$$" twice but not for "^.*$". - the code did not notice if dnNormalize2() failed, and would (at least in one case) treat a bad DN as '*'. Some cleanup: - changed regtest() to return void, since the return value was unused. - changed acl_regex_normalized_dn() to take a string input argument instead of a half-filled berval, it looks saner that way. Hallvard B. Furuseth , April 2002. --- diff --git a/servers/slapd/aclparse.c b/servers/slapd/aclparse.c index 1c8a5bad37..f53d273aa6 100644 --- a/servers/slapd/aclparse.c +++ b/servers/slapd/aclparse.c @@ -22,14 +22,14 @@ static void split(char *line, int splitchar, char **left, char **right); static void access_append(Access **l, Access *a); static void acl_usage(void) LDAP_GCCATTR((noreturn)); -static void acl_regex_normalized_dn(struct berval *pattern); +static void acl_regex_normalized_dn(const char *src, struct berval *pat); #ifdef LDAP_DEBUG static void print_acl(Backend *be, AccessControl *a); static void print_access(Access *b); #endif -static int +static void regtest(const char *fname, int lineno, char *pat) { int e; regex_t re; @@ -79,10 +79,8 @@ regtest(const char *fname, int lineno, char *pat) { "%s: line %d: regular expression \"%s\" bad because of %s\n", fname, lineno, pat, error ); acl_usage(); - return(0); } regfree(&re); - return(1); } void @@ -166,7 +164,7 @@ parse_acl( || strcmp(right, ".*") == 0 || strcmp(right, ".*$") == 0 || strcmp(right, "^.*") == 0 - || strcmp(right, "^.*$$") == 0 + || strcmp(right, "^.*$") == 0 || strcmp(right, ".*$$") == 0 || strcmp(right, "^.*$$") == 0 ) { @@ -174,8 +172,7 @@ parse_acl( a->acl_dn_pat.bv_len = sizeof("*")-1; } else { - a->acl_dn_pat.bv_val = right; - acl_regex_normalized_dn( &a->acl_dn_pat ); + acl_regex_normalized_dn( right, &a->acl_dn_pat ); } } else if ( strcasecmp( style, "base" ) == 0 ) { a->acl_dn_style = ACL_STYLE_BASE; @@ -236,7 +233,13 @@ parse_acl( if( a->acl_dn_pat.bv_len != 0 ) { if ( a->acl_dn_style != ACL_STYLE_REGEX ) { struct berval bv; - dnNormalize2( NULL, &a->acl_dn_pat, &bv); + rc = dnNormalize2( NULL, &a->acl_dn_pat, &bv); + if ( rc != LDAP_SUCCESS ) { + fprintf( stderr, + "%s: line %d: bad DN \"%s\"\n", + fname, lineno, a->acl_dn_pat.bv_val ); + acl_usage(); + } free( a->acl_dn_pat.bv_val ); a->acl_dn_pat = bv; } else { @@ -373,8 +376,7 @@ parse_acl( 1, &bv); } else { - bv.bv_val = right; - acl_regex_normalized_dn( &bv ); + acl_regex_normalized_dn( right, &bv ); if ( !ber_bvccmp( &bv, '*' ) ) { regtest(fname, lineno, bv.bv_val); } @@ -402,7 +404,13 @@ parse_acl( } if ( sty != ACL_STYLE_REGEX && expand == 0 ) { - dnNormalize2(NULL, &bv, &b->a_dn_pat); + rc = dnNormalize2(NULL, &bv, &b->a_dn_pat); + if ( rc != LDAP_SUCCESS ) { + fprintf( stderr, + "%s: line %d: bad DN \"%s\"\n", + fname, lineno, bv.bv_val ); + acl_usage(); + } free(bv.bv_val); } else { b->a_dn_pat = bv; @@ -490,15 +498,20 @@ parse_acl( b->a_group_style = sty; if (sty == ACL_STYLE_REGEX) { - bv.bv_val = right; - acl_regex_normalized_dn( &bv ); + acl_regex_normalized_dn( right, &bv ); if ( !ber_bvccmp( &bv, '*' ) ) { regtest(fname, lineno, bv.bv_val); } b->a_group_pat = bv; } else { ber_str2bv( right, 0, 0, &bv ); - dnNormalize2( NULL, &bv, &b->a_group_pat ); + rc = dnNormalize2( NULL, &bv, &b->a_group_pat ); + if ( rc != LDAP_SUCCESS ) { + fprintf( stderr, + "%s: line %d: bad DN \"%s\"\n", + fname, lineno, right ); + acl_usage(); + } } if (value && *value) { @@ -625,8 +638,7 @@ parse_acl( b->a_peername_style = sty; if (sty == ACL_STYLE_REGEX) { - bv.bv_val = right; - acl_regex_normalized_dn( &bv ); + acl_regex_normalized_dn( right, &bv ); if ( !ber_bvccmp( &bv, '*' ) ) { regtest(fname, lineno, bv.bv_val); } @@ -661,8 +673,7 @@ parse_acl( b->a_sockname_style = sty; if (sty == ACL_STYLE_REGEX) { - bv.bv_val = right; - acl_regex_normalized_dn( &bv ); + acl_regex_normalized_dn( right, &bv ); if ( !ber_bvccmp( &bv, '*' ) ) { regtest(fname, lineno, bv.bv_val); } @@ -704,8 +715,7 @@ parse_acl( b->a_domain_style = sty; b->a_domain_expand = expand; if (sty == ACL_STYLE_REGEX) { - bv.bv_val = right; - acl_regex_normalized_dn( &bv ); + acl_regex_normalized_dn( right, &bv ); if ( !ber_bvccmp( &bv, '*' ) ) { regtest(fname, lineno, bv.bv_val); } @@ -740,8 +750,7 @@ parse_acl( b->a_sockurl_style = sty; if (sty == ACL_STYLE_REGEX) { - bv.bv_val = right; - acl_regex_normalized_dn( &bv ); + acl_regex_normalized_dn( right, &bv ); if ( !ber_bvccmp( &bv, '*' ) ) { regtest(fname, lineno, bv.bv_val); } @@ -1270,25 +1279,26 @@ acl_usage( void ) } /* + * Set pattern to a "normalized" DN from src. * At present it simply eats the (optional) space after * a RDN separator (,) * Eventually will evolve in a more complete normalization - * - * Note that the input berval only needs bv_val, it ignores - * the input bv_len and sets it on return. */ static void acl_regex_normalized_dn( + const char *src, struct berval *pattern ) { char *str, *p; + ber_len_t len; - str = ch_strdup( pattern->bv_val ); + str = ch_strdup( src ); + len = strlen( src ); for ( p = str; p && p[ 0 ]; p++ ) { /* escape */ - if ( p[ 0 ] == '\\' ) { + if ( p[ 0 ] == '\\' && p[ 1 ] ) { /* * if escaping a hex pair we should * increment p twice; however, in that @@ -1309,7 +1319,7 @@ acl_regex_normalized_dn( for ( q = &p[ 2 ]; q[ 0 ] == ' '; q++ ) { /* DO NOTHING */ ; } - AC_MEMCPY( p+1, q, pattern->bv_len-(q-str)+1); + AC_MEMCPY( p+1, q, len-(q-str)+1); } } }