From: Michael Stapelberg <michael@stapelberg.de>
Date: Mon, 28 Jun 2010 19:40:36 +0000 (+0200)
Subject: automatically set dialog windows to floating
X-Git-Tag: tree-pr1~181
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=84e78c6dba6e41e38eff86b4ff387384e29f2c6b;p=i3%2Fi3

automatically set dialog windows to floating
---

diff --git a/src/manage.c b/src/manage.c
index 5f5bb44c..754ebb0f 100644
--- a/src/manage.c
+++ b/src/manage.c
@@ -163,6 +163,24 @@ void manage_window(xcb_window_t window, xcb_get_window_attributes_cookie_t cooki
     nc->window = cwindow;
     x_reinit(nc);
 
+    xcb_get_property_reply_t *reply = xcb_get_property_reply(conn, wm_type_cookie, NULL);
+    if (xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_DOCK]))
+        LOG("this window is a dock\n");
+
+    /* set floating if necessary */
+    if (xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_DIALOG]) ||
+        xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_UTILITY]) ||
+        xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_TOOLBAR]) ||
+        xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_SPLASH])) {
+        LOG("This window is a dialog window, setting floating\n");
+
+        /* We respect the geometry wishes of floating windows, as long as they
+         * are bigger than our minimal useful size (75x50). */
+        nc->rect.width = max(geom->width, 75);
+        nc->rect.height = max(geom->height, 50);
+        floating_enable(nc, false);
+    }
+
     /* to avoid getting an UnmapNotify event due to reparenting, we temporarily
      * declare no interest in any state change event of this window */
     values[0] = XCB_NONE;
@@ -178,21 +196,10 @@ void manage_window(xcb_window_t window, xcb_get_window_attributes_cookie_t cooki
     values[0] = CHILD_EVENT_MASK;
     xcb_change_window_attributes(conn, window, mask, values);
 
-    xcb_get_property_reply_t *reply = xcb_get_property_reply(conn, state_cookie, NULL);
+    reply = xcb_get_property_reply(conn, state_cookie, NULL);
     if (xcb_reply_contains_atom(reply, atoms[_NET_WM_STATE_FULLSCREEN]))
         con_toggle_fullscreen(nc);
 
-    reply = xcb_get_property_reply(conn, wm_type_cookie, NULL);
-    if (xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_DOCK]))
-        LOG("this window is a dock\n");
-
-    if (xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_DIALOG]) ||
-        xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_UTILITY]) ||
-        xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_TOOLBAR]) ||
-        xcb_reply_contains_atom(reply, atoms[_NET_WM_WINDOW_TYPE_SPLASH]))
-        LOG("This window is a dialog window\n");
-
-
     /* Put the client inside the save set. Upon termination (whether killed or
      * normal exit does not matter) of the window manager, these clients will
      * be correctly reparented to their most closest living ancestor (=