From: Hallvard Furuseth <hallvard@openldap.org>
Date: Thu, 19 Nov 1998 03:02:33 +0000 (+0000)
Subject: pass struct in_addr.s_addr*, not long*, to gethostbyaddr
X-Git-Tag: OPENLDAP_SLAPD_BACK_LDAP~1085
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=990f15d15d3e749052f3b6f2f556842123950718;p=openldap

pass struct in_addr.s_addr*, not long*, to gethostbyaddr
---

diff --git a/clients/finger/main.c b/clients/finger/main.c
index 0a53a63efb..e873b2e2ce 100644
--- a/clients/finger/main.c
+++ b/clients/finger/main.c
@@ -61,7 +61,6 @@ main( int argc, char **argv )
 {
 	int			i;
 	char			*myname;
-	unsigned long		mypeer = -1;
 	struct hostent		*hp;
 	struct sockaddr_in	peername;
 	int			peernamelen;
@@ -110,7 +109,6 @@ main( int argc, char **argv )
 			perror( "getpeername" );
 			exit( 1 );
 		}
-		mypeer = (unsigned long) peername.sin_addr.s_addr;
 	}
 
 #ifdef FINGER_BANNER
@@ -133,13 +131,12 @@ main( int argc, char **argv )
 #endif
 	}
 
-	if ( dosyslog && mypeer != (unsigned long) -1 ) {
-		struct in_addr	addr;
-
-		hp = gethostbyaddr( (char *) &mypeer, sizeof(mypeer), AF_INET );
-		addr.s_addr = mypeer;
-		syslog( LOG_INFO, "connection from %s (%s)", (hp == NULL) ?
-		    "unknown" : hp->h_name, inet_ntoa( addr ) );
+	if ( dosyslog && !interactive ) {
+		hp = gethostbyaddr( (char *) &peername.sin_addr.s_addr,
+				    sizeof(peername.sin_addr.s_addr), AF_INET );
+		syslog( LOG_INFO, "connection from %s (%s)",
+			(hp == NULL) ? "unknown" : hp->h_name,
+			inet_ntoa( peername.sin_addr ) );
 	}
 
 	do_query();