From: Pierangelo Masarati <ando@openldap.org>
Date: Thu, 17 Nov 2005 22:45:32 +0000 (+0000)
Subject: don't accept modify operations with no modifications (ITS#4183)
X-Git-Tag: OPENLDAP_REL_ENG_2_4_BP~790
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=99b450dc00545d93f001f45243576fbb6041f09d;p=openldap

don't accept modify operations with no modifications (ITS#4183)
---

diff --git a/servers/slapd/modify.c b/servers/slapd/modify.c
index 90c7d3c3a0..c4e35be7aa 100644
--- a/servers/slapd/modify.c
+++ b/servers/slapd/modify.c
@@ -169,6 +169,14 @@ do_modify(
 	}
 	*modtail = NULL;
 
+	if ( modlist == NULL ) {
+		Debug( LDAP_DEBUG_ANY, "do_modify: no modifications\n", 0, 0, 0 );
+		send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR,
+			"empty change secquence in modify operation" );
+
+		goto cleanup;
+	}
+
 	if( get_ctrls( op, rs, 1 ) != LDAP_SUCCESS ) {
 		Debug( LDAP_DEBUG_ANY, "do_modify: get_ctrls failed\n", 0, 0, 0 );