From: Øyvind Harboe Date: Mon, 31 Oct 2011 20:21:35 +0000 (+0100) Subject: warnings: null pointer check fix X-Git-Tag: v0.6.0-rc1~485 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=9b9092b7faa5859dd1a14489a312465782e2bef1;p=openocd warnings: null pointer check fix rewrite broken null pointer check code by reducing scope of variable. Change-Id: I8254f6849b187e5c9cd083053cdc11973c6fe339 Signed-off-by: Øyvind Harboe Reviewed-on: http://openocd.zylin.com/142 Tested-by: jenkins Reviewed-by: Spencer Oliver --- diff --git a/src/target/target_request.c b/src/target/target_request.c index 3cdca5e1..1fedfb22 100644 --- a/src/target/target_request.c +++ b/src/target/target_request.c @@ -194,11 +194,9 @@ static int add_debug_msg_receiver(struct command_context *cmd_ctx, struct target static struct debug_msg_receiver* find_debug_msg_receiver(struct command_context *cmd_ctx, struct target *target) { int do_all_targets = 0; - struct debug_msg_receiver **p = &target->dbgmsg; /* if no target has been specified search all of them */ - if (target == NULL) - { + if (target == NULL) { /* if no targets haven been specified */ if (all_targets == NULL) return NULL; @@ -207,8 +205,9 @@ static struct debug_msg_receiver* find_debug_msg_receiver(struct command_context do_all_targets = 1; } - do - { + /* so we target != null */ + struct debug_msg_receiver **p = &target->dbgmsg; + do { while (*p) { if ((*p)->cmd_ctx == cmd_ctx)