From: Howard Chu <hyc@openldap.org>
Date: Sat, 12 Jun 2004 05:29:55 +0000 (+0000)
Subject: ITS#3186 don't print error when empty DN "" is the only thing missing
X-Git-Tag: OPENDLAP_REL_ENG_2_2_MP~288
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=9cf45220d238acc374b074badbb70e3c4958b2ae;p=openldap

ITS#3186 don't print error when empty DN "" is the only thing missing
---

diff --git a/servers/slapd/back-bdb/tools.c b/servers/slapd/back-bdb/tools.c
index 226866431c..0ae213d032 100644
--- a/servers/slapd/back-bdb/tools.c
+++ b/servers/slapd/back-bdb/tools.c
@@ -68,12 +68,19 @@ int bdb_tool_entry_close(
 
 	if( nholes ) {
 		unsigned i;
-		fprintf( stderr, "Error, entries missing!\n");
+		int fail=0, warn=1;
 		for (i=0; i<nholes; i++) {
-			fprintf(stderr, "  entry %ld: %s\n",
-				holes[i].id, holes[i].dn.bv_val);
+			if (holes[i].dn.bv_len) {
+				fail=1;
+				if (warn) {
+					fprintf( stderr, "Error, entries missing!\n");
+					warn=0;
+				}
+				fprintf(stderr, "  entry %ld: %s\n",
+					holes[i].id, holes[i].dn.bv_val);
+			}
 		}
-		return -1;
+		if (fail) return -1;
 	}
 			
 	return 0;