From: Kurt Zeilenga <kurt@openldap.org>
Date: Tue, 3 Oct 2000 22:05:28 +0000 (+0000)
Subject: Fix add of empty value.
X-Git-Tag: LDBM_PRE_GIANT_RWLOCK~1815
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=9e450558d89453bf5918b8a4e9265ad80063a2bc;p=openldap

Fix add of empty value.
---

diff --git a/clients/tools/ldapmodify.c b/clients/tools/ldapmodify.c
index 59f2ce0911..2bb835a64e 100644
--- a/clients/tools/ldapmodify.c
+++ b/clients/tools/ldapmodify.c
@@ -1022,6 +1022,16 @@ domodify(
 	fprintf( stderr, "%s: no attributes to change or add (entry=\"%s\")\n",
 		prog, dn );
 	return( LDAP_PARAM_ERROR );
+    } 
+
+    for ( i = 0; pmods[ i ] != NULL; ++i ) {
+	op = pmods[ i ]->mod_op & ~LDAP_MOD_BVALUES;
+	if( op == LDAP_MOD_ADD && ( pmods[i]->mod_bvalues == NULL )) {
+		fprintf( stderr,
+			"%s: attribute \"%s\" has no values (entry=\"%s\")\n",
+			prog, pmods[i]->mod_type, dn );
+		return LDAP_PARAM_ERROR;
+	}
     }
 
     if ( verbose ) {
diff --git a/libraries/libldif/line64.c b/libraries/libldif/line64.c
index e101cd9e3e..947d35a616 100644
--- a/libraries/libldif/line64.c
+++ b/libraries/libldif/line64.c
@@ -116,7 +116,7 @@ ldif_parse_line(
 
 	if ( *s == '\0' ) {
 		/* no value */
-		value = NULL;
+		value = "";
 		vlen = 0;
 		goto done;
 	}