From: Orestis Floros <orestisf1993@gmail.com>
Date: Tue, 26 Sep 2017 09:29:40 +0000 (+0300)
Subject: i3bar: avoid possible va_args leak
X-Git-Tag: 4.15~34^2~1
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=a05663c59eb44112044725a416cd457efcbabd94;p=i3%2Fi3

i3bar: avoid possible va_args leak
---

diff --git a/i3bar/src/child.c b/i3bar/src/child.c
index fe989c44..170fcdef 100644
--- a/i3bar/src/child.c
+++ b/i3bar/src/child.c
@@ -106,7 +106,7 @@ __attribute__((format(printf, 1, 2))) static void set_statusline_error(const cha
     va_list args;
     va_start(args, format);
     if (vasprintf(&message, format, args) == -1) {
-        return;
+        goto finish;
     }
 
     struct status_block *err_block = scalloc(1, sizeof(struct status_block));
@@ -124,6 +124,7 @@ __attribute__((format(printf, 1, 2))) static void set_statusline_error(const cha
     TAILQ_INSERT_HEAD(&statusline_head, err_block, blocks);
     TAILQ_INSERT_TAIL(&statusline_head, message_block, blocks);
 
+finish:
     FREE(message);
     va_end(args);
 }