From: Howard Chu <hyc@openldap.org>
Date: Mon, 12 Jan 2004 04:09:52 +0000 (+0000)
Subject: Really fix ITS#2905
X-Git-Tag: OPENLDAP_REL_ENG_2_1_MP~37
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=a8dbfd322ac7c11ac5e338705d45160eb84cb455;p=openldap

Really fix ITS#2905
---

diff --git a/servers/slapd/back-bdb/tools.c b/servers/slapd/back-bdb/tools.c
index 93231fefbc..e73f7c70db 100644
--- a/servers/slapd/back-bdb/tools.c
+++ b/servers/slapd/back-bdb/tools.c
@@ -265,9 +265,8 @@ static int bdb_tool_next_id(
 	} else if ( !hole ) {
 		unsigned i;
 
-		if ( e->e_id == NOID ) {
-			return DB_KEYEXIST;
-		}
+		e->e_id = ei->bei_id;
+		rc = DB_KEYEXIST;
 
 		for ( i=0; i<nholes; i++) {
 			if ( holes[i].id == e->e_id ) {
@@ -276,6 +275,7 @@ static int bdb_tool_next_id(
 				for (j=i;j<nholes;j++) holes[j] = holes[j+1];
 				holes[j].id = 0;
 				nholes--;
+				rc = 0;
 				break;
 			} else if ( holes[i].id > e->e_id ) {
 				break;