From: Julio Sánchez Fernández <jsanchez@openldap.org>
Date: Tue, 23 Oct 2001 13:42:37 +0000 (+0000)
Subject: Remove bogus refusal to index ;binary attributes.  Notice that I left
X-Git-Tag: LDBM_PRE_GIANT_RWLOCK~937
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=aee598dba720783f20988d09c8804d199fcf807d;p=openldap

Remove bogus refusal to index ;binary attributes.  Notice that I left
in a check.  This way you have to say:

	index userCertificate eq

If we remove it, we could say:

	index userCertificate;binary eq

I have not tried the latter.
---

diff --git a/servers/slapd/back-bdb/index.c b/servers/slapd/back-bdb/index.c
index 71e902e764..aea035d431 100644
--- a/servers/slapd/back-bdb/index.c
+++ b/servers/slapd/back-bdb/index.c
@@ -24,9 +24,6 @@ static slap_mask_t index_mask(
 	AttributeType *at;
 	slap_mask_t mask = 0;
 
-	/* we do not support indexing of binary attributes */
-	if( slap_ad_is_binary( desc ) ) return 0;
-
 	bdb_attr_mask( be->be_private, desc->ad_cname.bv_val, &mask );
 
 	if( mask ) {
@@ -340,11 +337,6 @@ int bdb_index_values(
 	char *dbname = NULL;
 	slap_mask_t mask;
 
-	if( slap_ad_is_binary( desc ) ) {
-		/* binary attributes have no index capabilities */
-		return LDAP_SUCCESS;
-	}
-
 	rc = index_at_values( be, txn,
 		desc->ad_type, &desc->ad_lang,
 		vals, id, op,
diff --git a/servers/slapd/back-ldbm/index.c b/servers/slapd/back-ldbm/index.c
index baa197b3a3..1ab7d47bfb 100644
--- a/servers/slapd/back-ldbm/index.c
+++ b/servers/slapd/back-ldbm/index.c
@@ -24,9 +24,6 @@ static slap_mask_t index_mask(
 	AttributeType *at;
 	slap_mask_t mask = 0;
 
-	/* we do not support indexing of binary attributes */
-	if( slap_ad_is_binary( desc ) ) return 0;
-
 	attr_mask( be->be_private, desc->ad_cname.bv_val, &mask );
 
 	if( mask ) {
@@ -301,11 +298,6 @@ int index_values(
 	char *dbname = NULL;
 	slap_mask_t mask;
 
-	if( slap_ad_is_binary( desc ) ) {
-		/* binary attributes have no index capabilities */
-		return LDAP_SUCCESS;
-	}
-
 	(void) index_at_values( be,
 		desc->ad_type, &desc->ad_lang,
 		vals, id, op,