From: Howard Chu <hyc@openldap.org>
Date: Fri, 3 Dec 2004 17:28:33 +0000 (+0000)
Subject: ITS#3404, fix uninit'd ctrl fields
X-Git-Tag: OPENLDAP_REL_ENG_2_3_0ALPHA~143
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=b467dbb47043d531b3c2497c91a8abeec77118eb;p=openldap

ITS#3404, fix uninit'd ctrl fields
---

diff --git a/servers/slapd/controls.c b/servers/slapd/controls.c
index 76e470efe6..688e726607 100644
--- a/servers/slapd/controls.c
+++ b/servers/slapd/controls.c
@@ -523,6 +523,8 @@ int get_ctrls(
 
 			c->ldctl_iscritical = (crit != 0);
 			tag = ber_peek_tag( ber, &len );
+		} else {
+			c->ldctl_iscritical = 0;
 		}
 
 		if( tag == LBER_OCTETSTRING ) {
@@ -539,6 +541,8 @@ int get_ctrls(
 				rs->sr_text = "decoding controls error";
 				goto return_results;
 			}
+		} else {
+			BER_BVZERO( &c->ldctl_value );
 		}
 
 		Debug( LDAP_DEBUG_TRACE,