From: Luke Howard <lukeh@openldap.org>
Date: Tue, 2 Aug 2005 16:12:09 +0000 (+0000)
Subject: slapi/slapi_utils.c rev 1.172 removed the 'dup' parameter to
X-Git-Tag: OPENLDAP_AC_BP~100
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=b620a0e23ceabbf973b98856edb7178d1b24aab6;p=openldap

slapi/slapi_utils.c rev 1.172 removed the 'dup' parameter to
slapi_int_ldapmods2modifications(), but a 'dup' test remains in the
function body. Should always evaluate to TRUE.
---

diff --git a/servers/slapd/slapi/slapi_utils.c b/servers/slapd/slapi/slapi_utils.c
index 8d55601099..1f4396cd6a 100644
--- a/servers/slapd/slapi/slapi_utils.c
+++ b/servers/slapd/slapi/slapi_utils.c
@@ -2819,8 +2819,7 @@ Modifications *slapi_int_ldapmods2modifications ( LDAPMod **mods, void *memctx )
 				}
 			} else {
 				for ( i = 0; lmod->mod_values[i] != NULL; i++ ) {
-					mod->sml_values[i].bv_val = dup ? slapi_ch_strdup( lmod->mod_values[i] ) :
-						lmod->mod_values[i];
+					mod->sml_values[i].bv_val = slapi_ch_strdup( lmod->mod_values[i] );
 					mod->sml_values[i].bv_len = strlen( lmod->mod_values[i] );
 				}
 			}