From: Pierangelo Masarati <ando@openldap.org>
Date: Fri, 16 Sep 2005 15:00:13 +0000 (+0000)
Subject: issue additional useful warning messages; may eventually turn into errors?
X-Git-Tag: OPENLDAP_REL_ENG_2_2_MP~415
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=b79d4bdce510921f7d07d3d4757aa274b9b67df8;p=openldap

issue additional useful warning messages; may eventually turn into errors?
---

diff --git a/servers/slapd/aclparse.c b/servers/slapd/aclparse.c
index fd9a339ee7..e9f4a69655 100644
--- a/servers/slapd/aclparse.c
+++ b/servers/slapd/aclparse.c
@@ -455,6 +455,14 @@ parse_acl(
 				} else if ( strcasecmp( left, "attr" ) == 0		/* TOLERATED */
 						|| strcasecmp( left, "attrs" ) == 0 )	/* DOCUMENTED */
 				{
+					if ( strcasecmp( left, "attr" ) == 0 ) {
+						Debug( LDAP_DEBUG_ANY,
+							"%s: line %d: \"attr\" "
+							"is deprecated (and undocumented); "
+							"use \"attrs\" instead.\n",
+							fname, lineno, 0 );
+					}
+
 					a->acl_attrs = str2anlist( a->acl_attrs,
 						right, "," );
 					if ( a->acl_attrs == NULL ) {
@@ -967,6 +975,16 @@ parse_acl(
 							acl_usage();
 						}
 						free( bv.bv_val );
+						if ( sty == ACL_STYLE_BASE
+							&& be != NULL
+							&& !BER_BVISNULL( &be->be_rootndn )
+							&& dn_match( &bdn->a_pat, &be->be_rootndn ) )
+						{
+							Debug( LDAP_DEBUG_ANY,
+								"%s: line %d: rootdn is always granted "
+								"unlimited privileges.\n",
+								fname, lineno, 0 );
+						}
 
 					} else {
 						bdn->a_pat = bv;