From: oharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Date: Sat, 26 Jul 2008 19:12:30 +0000 (+0000)
Subject: add check for target_read/write_buffer 32 bit wrap.
X-Git-Tag: v0.1.0~424
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=b82a189c4e852d0f88a591aa8d7d28fda1387743;p=openocd

add check for target_read/write_buffer 32 bit wrap.

git-svn-id: svn://svn.berlios.de/openocd/trunk@875 b42882b7-edfa-0310-969c-e2dbd0fdcd60
---

diff --git a/src/target/target.c b/src/target/target.c
index 58a940bd..7c6beb0f 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -969,13 +969,20 @@ int target_arch_state(struct target_s *target)
 int target_write_buffer(struct target_s *target, u32 address, u32 size, u8 *buffer)
 {
 	int retval;
+	LOG_DEBUG("writing buffer of %i byte at 0x%8.8x", size, address);
+
 	if (!target->type->examined)
 	{
 		LOG_ERROR("Target not examined yet");
 		return ERROR_FAIL;
 	}
 	
-	LOG_DEBUG("writing buffer of %i byte at 0x%8.8x", size, address);
+	if (address+size<address)
+	{
+		/* GDB can request this when e.g. PC is 0xfffffffc*/
+		LOG_ERROR("address+size wrapped(0x%08x, 0x%08x)", address, size);
+		return ERROR_FAIL;
+	}
 	
 	if (((address % 2) == 0) && (size == 2))
 	{
@@ -1038,13 +1045,20 @@ int target_write_buffer(struct target_s *target, u32 address, u32 size, u8 *buff
 int target_read_buffer(struct target_s *target, u32 address, u32 size, u8 *buffer)
 {
 	int retval;
+	LOG_DEBUG("reading buffer of %i byte at 0x%8.8x", size, address);
+
 	if (!target->type->examined)
 	{
 		LOG_ERROR("Target not examined yet");
 		return ERROR_FAIL;
 	}
-
-	LOG_DEBUG("reading buffer of %i byte at 0x%8.8x", size, address);
+	
+	if (address+size<address)
+	{
+		/* GDB can request this when e.g. PC is 0xfffffffc*/
+		LOG_ERROR("address+size wrapped(0x%08x, 0x%08x)", address, size);
+		return ERROR_FAIL;
+	}
 	
 	if (((address % 2) == 0) && (size == 2))
 	{