From: Howard Chu <hyc@openldap.org>
Date: Tue, 18 Sep 2001 03:10:05 +0000 (+0000)
Subject: Fix crashes for SASL/EXTERNAL binds:
X-Git-Tag: LDBM_PRE_GIANT_RWLOCK~1095
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=bb06fd8d6b9df6d07787bdbb950abe1841c73cd1;p=openldap

Fix crashes for SASL/EXTERNAL binds:
  in slap_sasl_getdn, test id, not dn. dn is still NULL
  also, don't check for trailing slash
  in slap_sasl_bind, initialize reslen to 0
---

diff --git a/servers/slapd/sasl.c b/servers/slapd/sasl.c
index 29a83f5ada..3bcc33b738 100644
--- a/servers/slapd/sasl.c
+++ b/servers/slapd/sasl.c
@@ -112,7 +112,7 @@ int slap_sasl_getdn( Connection *conn, char *id, char **dnptr, int flags )
 	if( flags & FLAG_GETDN_AUTHCID ) {
 		if( sasl_external_x509dn_convert && conn->c_sasl_bind_mech
 			&& ( strcasecmp( "EXTERNAL", conn->c_sasl_bind_mech ) == 0 ) 
-			&& len && dn[0] == '/' && dn[len-1]== '/' )
+			&& len && id[0] == '/' /* && id[len-1]== '/' */)
 		{
 			/* check SASL external for X.509 style DN and */
 			/* convert to dn:<dn> form */
@@ -611,7 +611,7 @@ int slap_sasl_bind(
 #ifdef HAVE_CYRUS_SASL
 	sasl_conn_t *ctx = conn->c_sasl_context;
 	struct berval response;
-	unsigned reslen;
+	unsigned reslen = 0;
 	const char *errstr;
 	int sc;