From: Luca BRUNO <lucab@debian.org>
Date: Thu, 22 Aug 2013 14:22:31 +0000 (+0200)
Subject: NULL check before dereferencing
X-Git-Tag: v0.8.0-rc1~164
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=bb8c0d55d4fa72fe48ef70f17ee40324a355b73f;p=openocd

NULL check before dereferencing

Check reg_list[i]->feature for NULL pointers before checking feature->name
in order to avoid NULL access.

Change-Id: If20401a6c5aa5e1e29f0fcf9bb95585b49658832
Signed-off-by: Luca BRUNO <lucab@debian.org>
Reviewed-on: http://openocd.zylin.com/1809
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
Reviewed-by: Jens Bauer <jens@gpio.dk>
---

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index c49f87c1..c578780c 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -1988,7 +1988,8 @@ static int get_reg_features_list(struct target *target, char **feature_list[], i
 		if (reg_list[i]->exist == false)
 			continue;
 
-		if ((reg_list[i]->feature->name != NULL)
+		if (reg_list[i]->feature != NULL
+			&& reg_list[i]->feature->name != NULL
 			&& (strcmp(reg_list[i]->feature->name, ""))) {
 			/* We found a feature, check if the feature is already in the
 			 * table. If not, allocate a new entry for the table and