From: Pierangelo Masarati <ando@openldap.org>
Date: Tue, 22 Nov 2005 19:05:43 +0000 (+0000)
Subject: add a comment about reworking compare
X-Git-Tag: OPENLDAP_REL_ENG_2_4_BP~740
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=c1a845165efcc32ddbb38b2abffeb33349e4515c;p=openldap

add a comment about reworking compare
---

diff --git a/servers/slapd/overlays/dynlist.c b/servers/slapd/overlays/dynlist.c
index c10bafbcc4..93ec9f60e3 100644
--- a/servers/slapd/overlays/dynlist.c
+++ b/servers/slapd/overlays/dynlist.c
@@ -592,6 +592,11 @@ dynlist_response( Operation *op, SlapReply *rs )
 		/* NOTE: we waste a few cycles running the dynamic list
 		 * also when the result is FALSE, which occurs if the
 		 * dynamic entry itself contains the AVA attribute  */
+		/* FIXME: this approach is less than optimal; a dedicated
+		 * compare op should be implemented, that fetches the
+		 * entry, checks if it has the appropriate objectClass
+		 * and, in case, runs a compare thru all the URIs,
+		 * stopping at the first positive occurrence; see ITS#3756 */
 		case LDAP_COMPARE_FALSE:
 		case LDAP_NO_SUCH_ATTRIBUTE:
 			return dynlist_compare( op, rs );