From: oharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Date: Wed, 13 Aug 2008 15:12:26 +0000 (+0000)
Subject: comments.
X-Git-Tag: v0.1.0~386
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=c20eaea249dd60243d105cf590a6e43a087e596c;p=openocd

comments.

git-svn-id: svn://svn.berlios.de/openocd/trunk@913 b42882b7-edfa-0310-969c-e2dbd0fdcd60
---

diff --git a/src/target/target.h b/src/target/target.h
index bf009ea4..621640a9 100644
--- a/src/target/target.h
+++ b/src/target/target.h
@@ -162,12 +162,27 @@ typedef struct target_type_s
 	int (*checksum_memory)(struct target_s *target, u32 address, u32 count, u32* checksum);
 	int (*blank_check_memory)(struct target_s *target, u32 address, u32 count, u32* blank);
 	
-	/* target break-/watchpoint control 
-	* rw: 0 = write, 1 = read, 2 = access
-	*/
+	/* 
+	 * target break-/watchpoint control 
+	 * rw: 0 = write, 1 = read, 2 = access
+	 * 
+	 * Target must be halted while this is invoked as this
+	 * will actually set up breakpoints on target.
+	 * 
+	 * The breakpoint hardware will be set up upon adding the first breakpoint.
+	 * 
+	 * Upon GDB connection all breakpoints/watchpoints are cleared.
+	 */
 	int (*add_breakpoint)(struct target_s *target, breakpoint_t *breakpoint);
+	
+	/* remove breakpoint. hw will only be updated if the target is currently halted.
+	 * However, this method can be invoked on unresponsive targets.
+	 */
 	int (*remove_breakpoint)(struct target_s *target, breakpoint_t *breakpoint);
 	int (*add_watchpoint)(struct target_s *target, watchpoint_t *watchpoint);
+	/* remove watchpoint. hw will only be updated if the target is currently halted.
+	 * However, this method can be invoked on unresponsive targets.
+	 */
 	int (*remove_watchpoint)(struct target_s *target, watchpoint_t *watchpoint);
 
 	/* target algorithm support */