From: Olivier Gayot <olivier.gayot@sigexec.com>
Date: Wed, 20 Jun 2018 11:41:59 +0000 (+0200)
Subject: Prevent potential crash if glob() fails
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=c221b4d331d46d07fe24afc78e4eeb021556d013;p=i3%2Fi3status

Prevent potential crash if glob() fails

Calling globfree(NULL) is undefined behaviour. In Linux (glibc), it
results in a segmentation fault.

It is also undefined behaviour to call globfree(&pglob) if a previous
call to glob(&pglob) returned an error.

Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
---

diff --git a/src/print_battery_info.c b/src/print_battery_info.c
index 72c2d6f..04b5a25 100644
--- a/src/print_battery_info.c
+++ b/src/print_battery_info.c
@@ -459,8 +459,8 @@ static bool slurp_all_batteries(struct battery_info *batt_info, yajl_gen json_ge
             is_found = true;
             add_battery_info(batt_info, &batt_buf);
         }
+        globfree(&globbuf);
     }
-    globfree(&globbuf);
     free(globpath);
 
     if (!is_found) {