From: Michael Stapelberg <michael@stapelberg.de>
Date: Sat, 17 Apr 2010 11:54:45 +0000 (+0200)
Subject: handle client messages (fullscreen window state)
X-Git-Tag: tree-pr1~243
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=c56867792aa98ccedecfa40ca55e4a1a141a65c4;p=i3%2Fi3

handle client messages (fullscreen window state)
---

diff --git a/include/handlers.h b/include/handlers.h
index f5ea0591..270822b8 100644
--- a/include/handlers.h
+++ b/include/handlers.h
@@ -144,7 +144,6 @@ int handle_windowclass_change(void *data, xcb_connection_t *conn, uint8_t state,
  */
 int handle_expose_event(void *data, xcb_connection_t *conn,
                         xcb_expose_event_t *event);
-#if 0
 /**
  * Handle client messages (EWMH)
  *
@@ -152,6 +151,7 @@ int handle_expose_event(void *data, xcb_connection_t *conn,
 int handle_client_message(void *data, xcb_connection_t *conn,
                           xcb_client_message_event_t *event);
 
+#if 0
 /**
  * Handles _NET_WM_WINDOW_TYPE changes
  *
diff --git a/src/handlers.c b/src/handlers.c
index 510148d0..6b713169 100644
--- a/src/handlers.c
+++ b/src/handlers.c
@@ -642,36 +642,40 @@ int handle_expose_event(void *data, xcb_connection_t *conn, xcb_expose_event_t *
 #endif
 }
 
-#if 0
 /*
  * Handle client messages (EWMH)
  *
  */
 int handle_client_message(void *data, xcb_connection_t *conn, xcb_client_message_event_t *event) {
-        if (event->type == atoms[_NET_WM_STATE]) {
-                if (event->format != 32 || event->data.data32[1] != atoms[_NET_WM_STATE_FULLSCREEN])
-                        return 0;
-
-                Client *client = table_get(&by_child, event->window);
-                if (client == NULL)
-                        return 0;
-
-                /* Check if the fullscreen state should be toggled */
-                if ((client->fullscreen &&
-                     (event->data.data32[0] == _NET_WM_STATE_REMOVE ||
-                      event->data.data32[0] == _NET_WM_STATE_TOGGLE)) ||
-                    (!client->fullscreen &&
-                     (event->data.data32[0] == _NET_WM_STATE_ADD ||
-                      event->data.data32[0] == _NET_WM_STATE_TOGGLE)))
-                        client_toggle_fullscreen(conn, client);
-        } else {
-                ELOG("unhandled clientmessage\n");
-                return 0;
-        }
+    LOG("ClientMessage for window 0x%08x\n", event->window);
+    if (event->type == atoms[_NET_WM_STATE]) {
+        if (event->format != 32 || event->data.data32[1] != atoms[_NET_WM_STATE_FULLSCREEN])
+            return 0;
+
+        Con *con = con_by_window_id(event->window);
+        if (con == NULL)
+            return 0;
+
+        /* Check if the fullscreen state should be toggled */
+        if ((con->fullscreen_mode != CF_NONE &&
+             (event->data.data32[0] == _NET_WM_STATE_REMOVE ||
+              event->data.data32[0] == _NET_WM_STATE_TOGGLE)) ||
+            (con->fullscreen_mode == CF_NONE &&
+             (event->data.data32[0] == _NET_WM_STATE_ADD ||
+              event->data.data32[0] == _NET_WM_STATE_TOGGLE)))
+                con_toggle_fullscreen(con);
+
+        tree_render();
+        x_push_changes(croot);
+    } else {
+        ELOG("unhandled clientmessage\n");
+        return 0;
+    }
 
-        return 1;
+    return 1;
 }
 
+#if 0
 int handle_window_type(void *data, xcb_connection_t *conn, uint8_t state, xcb_window_t window,
                         xcb_atom_t atom, xcb_get_property_reply_t *property) {
         /* TODO: Implement this one. To do this, implement a little test program which sleep(1)s
diff --git a/src/nc.c b/src/nc.c
index 92dba08d..869a6f86 100644
--- a/src/nc.c
+++ b/src/nc.c
@@ -279,6 +279,9 @@ int main(int argc, char *argv[]) {
     /* Enter window = user moved his mouse over the window */
     xcb_event_set_enter_notify_handler(&evenths, handle_enter_notify, NULL);
 
+    /* Client message are sent to the root window. The only interesting client message
+       for us is _NET_WM_STATE, we honour _NET_WM_STATE_FULLSCREEN */
+    xcb_event_set_client_message_handler(&evenths, handle_client_message, NULL);
 
     /* Setup NetWM atoms */
     #define GET_ATOM(name) \