From: Heiko Stübner Date: Sat, 6 May 2017 19:21:29 +0000 (+0200) Subject: power: rk808: fix ldo register offset X-Git-Tag: v2017.07-rc2~80^2~59 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=d1bf69d822724d427b23e289b0c2cf9275c1e99e;p=u-boot power: rk808: fix ldo register offset Till now get_ldo_reg did a return &rk808_ldo[num - 1]; to return the ldo register offset but didn't take into account that its calling functions already created the ldo as ldo = dev->driver_data - 1. This resulted in the setting for ldo8 writing to the register of ldo7 and so on. So fix this and get the correct ldo register data. Signed-off-by: Heiko Stuebner Acked-by: Simon Glass --- diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c index e655c2d91f..c1ece96b66 100644 --- a/drivers/power/regulator/rk8xx.c +++ b/drivers/power/regulator/rk8xx.c @@ -92,9 +92,9 @@ static const struct rk8xx_reg_info *get_ldo_reg(struct udevice *pmic, struct rk8xx_priv *priv = dev_get_priv(pmic); switch (priv->variant) { case RK818_ID: - return &rk818_ldo[num - 1]; + return &rk818_ldo[num]; default: - return &rk808_ldo[num - 1]; + return &rk808_ldo[num]; } }