From: Hallvard Furuseth <hallvard@openldap.org>
Date: Tue, 10 May 2016 05:11:44 +0000 (+0200)
Subject: Comment ovpage code in mdb_cursor_put()
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=e2b8b6448de7de5229a44e18c224e3a670da4bdc;p=openldap

Comment ovpage code in mdb_cursor_put()
---

diff --git a/libraries/liblmdb/mdb.c b/libraries/liblmdb/mdb.c
index 72294a7e51..f3ca42755c 100644
--- a/libraries/liblmdb/mdb.c
+++ b/libraries/liblmdb/mdb.c
@@ -7468,8 +7468,13 @@ current:
 					/* Note - this page is already counted in parent's dirty_room */
 					rc2 = mdb_mid2l_insert(mc->mc_txn->mt_u.dirty_list, &id2);
 					mdb_cassert(mc, rc2 == 0);
+					/* Currently we make the page look as with put() in the
+					 * parent txn, in case the user peeks at MDB_RESERVEd
+					 * or unused parts. Some users treat ovpages specially.
+					 */
 					if (!(flags & MDB_RESERVE)) {
-						/* Copy end of page, adjusting alignment so
+						/* Skip the part where LMDB will put *data.
+						 * Copy end of page, adjusting alignment so
 						 * compiler may copy words instead of bytes.
 						 */
 						off = (PAGEHDRSZ + data->mv_size) & -sizeof(size_t);