From: Paul Fertser <fercerpav@gmail.com>
Date: Mon, 7 Apr 2014 08:33:53 +0000 (+0400)
Subject: target/cortex_a: check gdb_service before dereferencing in update_halt_gdb
X-Git-Tag: v0.8.0-rc2~13
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=ee54f7e9f0ad096d8db91a302c70d18d250db74b;p=openocd

target/cortex_a: check gdb_service before dereferencing in update_halt_gdb

If gdb was disconnected by the moment the target entered halted state,
update_halt_gdb would segfault.

Change-Id: I67477e9199c1df097be83a49e38602f975c083f5
Reported-by: Younes REGAIEG <younes.regaieg@imag.fr>
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2098
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
---

diff --git a/src/target/cortex_a.c b/src/target/cortex_a.c
index e95297cb..50eb9d48 100644
--- a/src/target/cortex_a.c
+++ b/src/target/cortex_a.c
@@ -766,7 +766,7 @@ static int cortex_a8_halt_smp(struct target *target)
 static int update_halt_gdb(struct target *target)
 {
 	int retval = 0;
-	if (target->gdb_service->core[0] == -1) {
+	if (target->gdb_service && target->gdb_service->core[0] == -1) {
 		target->gdb_service->target = target;
 		target->gdb_service->core[0] = target->coreid;
 		retval += cortex_a8_halt_smp(target);